chrome/browser/chromeos/login/ui/login_display_host_impl.cc - Issue 1356713004: Fix crash when locking screen while adding a user to an existing session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Issue 1356713004: Fix crash when locking screen while adding a user to an existing session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Proper fix Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

index ae9d5658b54785dccebd2a9b6c24d4c10a5518a3..f3d283e9076129a5e4c7e65951365ef35b6a9793 100644

--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

@@ -916,7 +916,7 @@ void LoginDisplayHostImpl::ShutdownDisplayHost(bool post_quit_task) {

base::MessageLoop::current()->Quit();

if (!completion_callback_.is_null())

- completion_callback_.Run();

+ base::MessageLoop::current()->PostTask(FROM_HERE, completion_callback_);

dzhioev (left Google) 2015/09/24 23:51:17 Can you please explain, how this helps to prevent

}

void LoginDisplayHostImpl::ScheduleWorkspaceAnimation() {

« no previous file with comments | « chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc ('k') | no next file » | no next file with comments »