sdk/lib/html/html_common/conversions_dartium.dart - Issue 1356653003: Operator precedence in isJavaScriptSimpleObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/html_common/conversions_dartium.dart

Issue 1356653003: Operator precedence in isJavaScriptSimpleObject (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/html_common/conversions_dartium.dart

diff --git a/sdk/lib/html/html_common/conversions_dartium.dart b/sdk/lib/html/html_common/conversions_dartium.dart

index fc7ca61360b1dba6bef2d672ce93ffc795d0028b..2eb2b8803cde18674bf510ce359eaf72ceea58f6 100644

--- a/sdk/lib/html/html_common/conversions_dartium.dart

+++ b/sdk/lib/html/html_common/conversions_dartium.dart

@@ -44,7 +44,7 @@ _getProto(object) {

final _objectProto = js.context["Object"]["prototype"];

bool isJavaScriptSimpleObject(value) {

- if (!value is js.JsObject) return false;

+ if (value is! js.JsObject) return false;

var proto = _getProto(value);

return proto == _objectProto || proto == null;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »