Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1356603005: [x64] Tweaking kMaxSizeEarlyOpt value to recover SunSpider/3d-cube. (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Tweaking kMaxSizeEarlyOpt value to recover SunSpider/3d-cube. With the IC-less global variables accesses the size of the Rotate* functions became small enough to be immediately optimized by Crankshaft which in turn tanked SunSpider/3d-cube. BUG=chromium:531338 LOG=N Committed: https://crrev.com/667c5e01402abd7b4ec4593b75f37b0cda2f5131 Cr-Commit-Position: refs/heads/master@{#30861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
Maybe it's worth landing: see results on "v8_linux64_haswell_perf_try".
5 years, 3 months ago (2015-09-22 08:16:04 UTC) #2
Benedikt Meurer
lgtm
5 years, 3 months ago (2015-09-22 08:36:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356603005/1
5 years, 3 months ago (2015-09-22 08:38:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 08:39:51 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 08:40:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/667c5e01402abd7b4ec4593b75f37b0cda2f5131
Cr-Commit-Position: refs/heads/master@{#30861}

Powered by Google App Engine
This is Rietveld 408576698