tools/metrics/histograms/histograms.xml - Issue 1356573002: [Smart Lock, Settings Reconciliation] Histograms for tracking initial pref values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1356573002: [Smart Lock, Settings Reconciliation] Histograms for tracking initial pref values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reconcile

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/password_manager/password_manager_setting_migrator_service.cc ('K') | « chrome/browser/password_manager/password_manager_setting_migrator_service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 49b59a31024ffe7d749bbb3955d0ad121d526a79..5aa226690148428b16ad37535ec17f174decdcba 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -30244,6 +30244,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PasswordManager.SettingsReconciliation.InitialValues"

+ enum="PasswordManagerPreferencesInitialValues">

+ <owner>engedy@chromium.org</owner>

+ <owner>melandory@chromium.org</owner>

+ <summary>

+ Tracks the pair of initial values for both for the legacy preference for

+ controlling the Chrome Password Manager and new preference for controlling

+ Smart Lock on Android. Sample is recorded on every profile initialization,

engedy 2015/09/28 10:03:48 nit: mention that this is recorded before running

melandory 2015/09/29 09:33:41 Done.

+ e.g. when user logs in to browser, on a startup of a browser.

+ </summary>

+</histogram>

<owner>vabr@chromium.org</owner>

@@ -66875,6 +66887,18 @@ To add a new entry, add it with any value and run test to compute valid value.

label="Password status not checked as user is on a Windows Domain"/>

</enum>

+<enum name="PasswordManagerPreferencesInitialValues" type="int">

+ <summary>

+ The pair of initial values for the legacy preference for controlling the

+ Chrome Password Manager and new preference for controlling Smart Lock on

+ Android.

+ </summary>

+ <int value="0" label="New pref is 'off', legacy pref is 'off'"/>

+ <int value="1" label="New pref is 'off', legacy pref is 'on'"/>

+ <int value="2" label="New pref is 'on', legacy pref is 'off'"/>

+ <int value="3" label="New pref is 'on', legacy pref is 'on'"/>

+</enum>

The value indicates whether an entry returned by password autofill contains