Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1356533002: Reland "[heap] Introduce parallel compaction algorithm." (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Introduce parallel compaction algorithm." This reverts commit 7a0a0b8b85e4cdf06795ffea01855b345776b932. - The number of parallel tasks is still 1, i.e., we only compact on the main thread. - Remove emergency memory (PagedSpace, and CodeRange) - Introduce partial compaction of pages. - Logic for multiple tasks is in place. BUG=chromium:524425 LOG=N Committed: https://crrev.com/7af79ae67ab48858c4c5f5a2d6df8e41f7658eeb Cr-Commit-Position: refs/heads/master@{#30796}

Patch Set 1 : Baseline #

Patch Set 2 : Unbreak lock cycle on main thread (TSAN warning) #

Total comments: 2

Patch Set 3 : Deduce need for locks based on space types #

Patch Set 4 : Remove outdated comment from first try #

Patch Set 5 : Fix accounting for moved free list memory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -200 lines) Patch
M src/heap/mark-compact.h View 2 chunks +13 lines, -5 lines 0 comments Download
M src/heap/mark-compact.cc View 10 chunks +135 lines, -84 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 4 14 chunks +66 lines, -23 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 11 chunks +37 lines, -88 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/1356533002/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1356533002/diff/20001/src/heap/spaces.cc#newcode986 src/heap/spaces.cc:986: void PagedSpace::MoveOverFreeMemory(PagedSpace* other, bool other_is_local) { As discussed offline: ...
5 years, 3 months ago (2015-09-17 09:09:46 UTC) #2
Michael Lippautz
Working on the api test failure now. https://codereview.chromium.org/1356533002/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1356533002/diff/20001/src/heap/spaces.cc#newcode986 src/heap/spaces.cc:986: void PagedSpace::MoveOverFreeMemory(PagedSpace* ...
5 years, 3 months ago (2015-09-17 09:27:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356533002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356533002/80001
5 years, 3 months ago (2015-09-17 11:10:10 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 3 months ago (2015-09-17 11:53:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356533002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356533002/80001
5 years, 3 months ago (2015-09-17 11:53:33 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-17 12:23:52 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 12:24:07 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7af79ae67ab48858c4c5f5a2d6df8e41f7658eeb
Cr-Commit-Position: refs/heads/master@{#30796}

Powered by Google App Engine
This is Rietveld 408576698