Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135653016: Clean up run-blink-httpd, run-blink-websocketserver, add tests. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 10 months ago
Reviewers:
scottmg
CC:
blink-reviews
Visibility:
Public.

Description

Clean up run-blink-httpd, run-blink-websocketserver, add tests. Last in the series of refactoring patches to clean up all the layout test server code and helpers. R=scottmg@chromium.org BUG=30536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167562

Patch Set 1 #

Patch Set 2 : merge forward changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -145 lines) Patch
M Tools/Scripts/run-blink-httpd View 1 1 chunk +3 lines, -64 lines 0 comments Download
M Tools/Scripts/run-blink-websocketserver View 1 chunk +4 lines, -40 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 1 chunk +1 line, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper.py View 2 chunks +21 lines, -28 lines 0 comments Download
A Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py View 1 chunk +34 lines, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/lighttpd.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Dirk Pranke
This is the last patch in this series of refactoring cleanups, and depends on the ...
6 years, 10 months ago (2014-02-11 22:30:12 UTC) #1
scottmg
unsubscribe lgtm
6 years, 10 months ago (2014-02-11 22:39:09 UTC) #2
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-21 00:22:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/135653016/40001
6 years, 10 months ago (2014-02-21 00:23:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 00:46:37 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=16425
6 years, 10 months ago (2014-02-21 00:46:38 UTC) #6
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-21 01:38:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/135653016/40001
6 years, 10 months ago (2014-02-21 01:38:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:00:26 UTC) #9
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=16434
6 years, 10 months ago (2014-02-21 02:00:26 UTC) #10
Dirk Pranke
Committed patchset #2 manually as r167562 (presubmit successful).
6 years, 10 months ago (2014-02-21 02:41:38 UTC) #11
Dirk Pranke
6 years, 10 months ago (2014-02-21 02:43:41 UTC) #12
Message was sent while issue was closed. 
I think the checkperms issue is a false negative. I landed this manually and
will watch the tree.

Powered by Google App Engine
This is Rietveld 408576698