Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: Source/core/html/HTMLImport.h

Issue 135653006: [import] Refactoring: Get rid of BlockedFromCreatingDocument state (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLImport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLImport.h
diff --git a/Source/core/html/HTMLImport.h b/Source/core/html/HTMLImport.h
index 1ee95425fa06c910c85ba308908771515cfc0a12..9ecc0254a14eabe3860251270d4f3dba7fd10807 100644
--- a/Source/core/html/HTMLImport.h
+++ b/Source/core/html/HTMLImport.h
@@ -141,9 +141,10 @@ public:
bool isCreatedByParser() const { return m_createdByParser; }
bool isBlockedFromRunningScript() const { return m_state <= BlockedFromRunningScript; }
- bool isBlockedFromCreatingDocument() const { return m_state <= BlockedFromCreatingDocument; }
bool isBlocked() const { return m_state < Ready; }
+ bool isBlockedFromCreatingDocument() const;
+
void appendChild(HTMLImport*);
virtual HTMLImportRoot* root() = 0;
@@ -151,12 +152,12 @@ public:
virtual void wasDetachedFromDocument() = 0;
virtual void didFinishParsing() = 0;
virtual bool isDone() const = 0; // FIXME: Should be renamed to haveFinishedLoading()
+ virtual bool hasLoader() const = 0;
virtual bool ownsLoader() const { return false; }
virtual CustomElementMicrotaskImportStep* customElementMicrotaskStep() const { return 0; }
protected:
enum State {
- BlockedFromCreatingDocument,
BlockedFromRunningScript,
WaitingLoaderOrChildren,
Ready
@@ -179,13 +180,10 @@ private:
void blockPredecessorsOf(HTMLImport* child);
void blockFromRunningScript();
- void blockFromCreatingDocument();
void waitLoaderOrChildren();
void unblockFromRunningScript();
- void unblockFromCreatingDocument();
void becomeReady();
- bool isBlockedFromCreatingDocumentByPredecessors() const;
bool isBlockedFromRunningScriptByPredecessors() const;
bool isBlockingFollowersFromRunningScript() const;
bool isBlockingFollowersFromCreatingDocument() const;
« no previous file with comments | « no previous file | Source/core/html/HTMLImport.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698