Issue 135653006: [import] Refactoring: Get rid of BlockedFromCreatingDocument state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135653006: [import] Refactoring: Get rid of BlockedFromCreatingDocument state (Closed)

Created:
6 years, 11 months ago by Hajime Morrita

Modified:
6 years, 11 months ago

Reviewers:
dglazkov1, dglazkov, dominicc (has gone to gerrit)

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[import] Refactoring: Get rid of BlockedFromCreatingDocument state The state can be inferred by existing state of the object. So we can remove it and just compute the predicate. BUG=none TEST=none R=dominicc,dglazkov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165250

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -30 lines)			Patch
M	Source/core/html/HTMLImport.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLImport.cpp	View	5 chunks	+6 lines, -23 lines	0 comments	Download
M	Source/core/html/HTMLImportChild.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLImportChild.cpp	View	3 chunks	+6 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLImportsController.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/HTMLImportsController.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/135653006/1

6 years, 11 months ago (2014-01-16 17:33:18 UTC) #3

Message was sent while issue was closed.

Change committed as 165250

Expand Messages | Collapse Messages