Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: Source/modules/indexeddb/IDBRequest.h

Issue 135653002: Update modules classes to use OVERRIDE / FINAL when needed (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove change to web/ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 virtual void onSuccess(int64_t); 103 virtual void onSuccess(int64_t);
104 virtual void onSuccess(); 104 virtual void onSuccess();
105 virtual void onSuccess(PassRefPtr<IDBKey>, PassRefPtr<IDBKey> primaryKey, Pa ssRefPtr<SharedBuffer>); 105 virtual void onSuccess(PassRefPtr<IDBKey>, PassRefPtr<IDBKey> primaryKey, Pa ssRefPtr<SharedBuffer>);
106 106
107 // Only IDBOpenDBRequest instances should receive these: 107 // Only IDBOpenDBRequest instances should receive these:
108 virtual void onBlocked(int64_t oldVersion) { ASSERT_NOT_REACHED(); } 108 virtual void onBlocked(int64_t oldVersion) { ASSERT_NOT_REACHED(); }
109 virtual void onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<blink::WebIDBDat abase>, const IDBDatabaseMetadata&, blink::WebIDBDataLoss, String dataLossMessag e) { ASSERT_NOT_REACHED(); } 109 virtual void onUpgradeNeeded(int64_t oldVersion, PassOwnPtr<blink::WebIDBDat abase>, const IDBDatabaseMetadata&, blink::WebIDBDataLoss, String dataLossMessag e) { ASSERT_NOT_REACHED(); }
110 virtual void onSuccess(PassOwnPtr<blink::WebIDBDatabase>, const IDBDatabaseM etadata&) { ASSERT_NOT_REACHED(); } 110 virtual void onSuccess(PassOwnPtr<blink::WebIDBDatabase>, const IDBDatabaseM etadata&) { ASSERT_NOT_REACHED(); }
111 111
112 // ActiveDOMObject 112 // ActiveDOMObject
113 virtual bool hasPendingActivity() const OVERRIDE; 113 virtual bool hasPendingActivity() const OVERRIDE FINAL;
114 virtual void stop() OVERRIDE; 114 virtual void stop() OVERRIDE FINAL;
115 115
116 // EventTarget 116 // EventTarget
117 virtual const AtomicString& interfaceName() const OVERRIDE; 117 virtual const AtomicString& interfaceName() const OVERRIDE;
118 virtual ExecutionContext* executionContext() const OVERRIDE; 118 virtual ExecutionContext* executionContext() const OVERRIDE FINAL;
119 virtual void uncaughtExceptionInEventHandler() OVERRIDE; 119 virtual void uncaughtExceptionInEventHandler() OVERRIDE FINAL;
120 120
121 using EventTarget::dispatchEvent; 121 using EventTarget::dispatchEvent;
122 virtual bool dispatchEvent(PassRefPtr<Event>) OVERRIDE; 122 virtual bool dispatchEvent(PassRefPtr<Event>) OVERRIDE;
123 123
124 // Called by a version change transaction that has finished to set this 124 // Called by a version change transaction that has finished to set this
125 // request back from DONE (following "upgradeneeded") back to PENDING (for 125 // request back from DONE (following "upgradeneeded") back to PENDING (for
126 // the upcoming "success" or "error"). 126 // the upcoming "success" or "error").
127 void transactionDidFinishAndDispatch(); 127 void transactionDidFinishAndDispatch();
128 128
129 virtual void deref() OVERRIDE 129 virtual void deref() OVERRIDE FINAL
130 { 130 {
131 if (derefBase()) 131 if (derefBase())
132 delete this; 132 delete this;
133 else if (hasOneRef()) 133 else if (hasOneRef())
134 checkForReferenceCycle(); 134 checkForReferenceCycle();
135 } 135 }
136 136
137 DOMRequestState* requestState() { return &m_requestState; } 137 DOMRequestState* requestState() { return &m_requestState; }
138 IDBCursor* getResultCursor() const; 138 IDBCursor* getResultCursor() const;
139 139
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 bool m_didFireUpgradeNeededEvent; 174 bool m_didFireUpgradeNeededEvent;
175 bool m_preventPropagation; 175 bool m_preventPropagation;
176 bool m_resultDirty; 176 bool m_resultDirty;
177 177
178 DOMRequestState m_requestState; 178 DOMRequestState m_requestState;
179 }; 179 };
180 180
181 } // namespace WebCore 181 } // namespace WebCore
182 182
183 #endif // IDBRequest_h 183 #endif // IDBRequest_h
OLDNEW
« no previous file with comments | « Source/modules/indexeddb/IDBOpenDBRequest.h ('k') | Source/modules/indexeddb/IDBRequestTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698