Issue 1356503003: data-fetcher: Discard really big data URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1356503003: data-fetcher: Discard really big data URLs. (Closed)

Created:
5 years, 3 months ago by sadrul

Modified:
5 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

data-fetcher: Discard really big data URLs. If the data URL size doesn't fit in 32 bits, then it's probably too large for anything useful (and correctly handling this case can be tricky). So discard it. BUG=531560 Committed: https://crrev.com/1ab3e0a11d1b06bbbf679fc3d61bb930748f9906 Cr-Commit-Position: refs/heads/master@{#349701}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	mojo/fetcher/data_fetcher.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356503003/1

5 years, 3 months ago (2015-09-18 16:50:19 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-18 17:25:21 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1ab3e0a11d1b06bbbf679fc3d61bb930748f9906
Cr-Commit-Position: refs/heads/master@{#349701}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages