Issue 13565004: Revert 192525 "Context menu on views must show on mouse down for..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13565004: Revert 192525 "Context menu on views must show on mouse down for..." (Closed)

Created:
7 years, 8 months ago by tkent

Modified:
7 years, 8 months ago

Reviewers:
varunjain

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 192525 "Context menu on views must show on mouse down for..." > Context menu on views must show on mouse down for non-WIN. > This is mostly a copy of https://chromiumcodereview.appspot.com/12395010 which was reverted due to a regression (https://code.google.com/p/chromium/issues/detail?id=189100). I have attempted to fix that regression here. > > BUG=189100, 179381 > > Review URL: https://chromiumcodereview.appspot.com/12529012 TBR=varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192532

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -172 lines)			Patch
M	trunk/src/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc	View	6 chunks	+5 lines, -25 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/browser_action_view.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	trunk/src/ui/views/controls/menu/menu_controller.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	trunk/src/ui/views/controls/menu/menu_controller.cc	View	4 chunks	+2 lines, -19 lines	0 comments	Download
M	trunk/src/ui/views/view.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/ui/views/view.cc	View	4 chunks	+3 lines, -28 lines	0 comments	Download
M	trunk/src/ui/views/widget/widget.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ui/views/widget/widget.cc	View	2 chunks	+7 lines, -51 lines	0 comments	Download
M	trunk/src/ui/views/widget/widget_unittest.cc	View	1 chunk	+0 lines, -35 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r192532.