Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1356493004: Make deps of GN groups public. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, Matt Giuca, chromoting-reviews_chromium.org, tfarina, jam, yurys, darin-cc_chromium.org, tapted, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make deps of GN groups public. Theses are implicitly public today, but I'm going to remove some transitional code that will change the default to be private. Some template instantiations needed to be updated that themselves expand to groups. Committed: https://crrev.com/717185dc6e6c480e7aa7969153f235eb450e12cf Cr-Commit-Position: refs/heads/master@{#349747}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -44 lines) Patch
M base/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/BUILD.gn View 1 2 6 chunks +14 lines, -14 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M components/resources/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/strings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/android/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/resources/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/BUILD.gn View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ui/resources/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/resources/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356493004/1
5 years, 3 months ago (2015-09-17 22:30:44 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/117679) linux_chromium_rel_ng on ...
5 years, 3 months ago (2015-09-17 22:39:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356493004/20001
5 years, 3 months ago (2015-09-17 22:55:08 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/134101)
5 years, 3 months ago (2015-09-17 23:31:09 UTC) #8
brettw
5 years, 3 months ago (2015-09-18 17:01:54 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356493004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356493004/40001
5 years, 3 months ago (2015-09-18 17:02:14 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 17:34:50 UTC) #14
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-18 19:22:09 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356493004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356493004/40001
5 years, 3 months ago (2015-09-18 19:52:32 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-18 19:59:04 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 19:59:40 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/717185dc6e6c480e7aa7969153f235eb450e12cf
Cr-Commit-Position: refs/heads/master@{#349747}

Powered by Google App Engine
This is Rietveld 408576698