Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: cc/output/output_surface.cc

Issue 1356463002: Revert of cc: Implement shared worker contexts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/output_surface.h ('k') | cc/raster/tile_task_worker_pool_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/output_surface.cc
diff --git a/cc/output/output_surface.cc b/cc/output/output_surface.cc
index dd6e54fb955d1a473f035aafbc1c50ba668eafbd..056879f49d84ba444142101690da109437208d14 100644
--- a/cc/output/output_surface.cc
+++ b/cc/output/output_surface.cc
@@ -32,7 +32,6 @@
device_scale_factor_(-1),
external_stencil_test_enabled_(false),
weak_ptr_factory_(this) {
- client_thread_checker_.DetachFromThread();
}
OutputSurface::OutputSurface(
@@ -102,8 +101,12 @@
}
OutputSurface::~OutputSurface() {
- if (client_)
- DetachFromClient();
+ if (context_provider_.get()) {
+ context_provider_->SetLostContextCallback(
+ ContextProvider::LostContextCallback());
+ context_provider_->SetMemoryPolicyChangedCallback(
+ ContextProvider::MemoryPolicyChangedCallback());
+ }
}
bool OutputSurface::HasExternalStencilTest() const {
@@ -111,9 +114,7 @@
}
bool OutputSurface::BindToClient(OutputSurfaceClient* client) {
- DCHECK(client_thread_checker_.CalledOnValidThread());
DCHECK(client);
- DCHECK(!client_);
client_ = client;
bool success = true;
@@ -127,24 +128,16 @@
}
}
+ if (success && worker_context_provider_.get()) {
+ success = worker_context_provider_->BindToCurrentThread();
+ if (success)
+ worker_context_provider_->SetupLock();
+ }
+
if (!success)
client_ = NULL;
return success;
-}
-
-void OutputSurface::DetachFromClient() {
- DCHECK(client_thread_checker_.CalledOnValidThread());
- DCHECK(client_);
- if (context_provider_.get()) {
- context_provider_->SetLostContextCallback(
- ContextProvider::LostContextCallback());
- context_provider_->SetMemoryPolicyChangedCallback(
- ContextProvider::MemoryPolicyChangedCallback());
- }
- context_provider_ = nullptr;
- client_ = nullptr;
- weak_ptr_factory_.InvalidateWeakPtrs();
}
void OutputSurface::EnsureBackbuffer() {
« no previous file with comments | « cc/output/output_surface.h ('k') | cc/raster/tile_task_worker_pool_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698