Issue 135643006: Fix test failure for 32 bit official build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135643006: Fix test failure for 32 bit official build. (Closed)

Created:
6 years, 11 months ago by avallee

Modified:
6 years, 11 months ago

Reviewers:
danakj

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix test failure for 32 bit official build. Official 32 bit builds seem to generate x86 fpu instructions while normal development settings and Chromium settings generate SSE instructions. GCC has a loss of precision bug (gcc.gnu.org/PR323) that results in a different floating point value in some cases. This bug can be worked around by storing the intermediate value in a variable. BUG=334475 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245343

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	ui/gfx/animation/tween.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avallee@chromium.org/135643006/1

6 years, 11 months ago (2014-01-16 17:08:34 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247362

6 years, 11 months ago (2014-01-16 18:43:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avallee@chromium.org/135643006/1

6 years, 11 months ago (2014-01-16 20:27:32 UTC) #5

Message was sent while issue was closed.

Change committed as 245343

Expand Messages | Collapse Messages