Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 135643005: drive: Stop using DictionaryValue to store data in FakeDriveService (Closed)

Created:
6 years, 11 months ago by hashimoto
Modified:
6 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews
Visibility:
Public.

Description

drive: Stop using DictionaryValue to store data in FakeDriveService Replace the giant DictionaryValue with std::map. No behavior change is intended. Remove unused FakeDriveService::FindEntryByContentUrl(). Fix util::ConvertResourceEntryToFileResource() to set EntryKind of hosted documents correctly. Stop depending on the results' order in SearchOperationTest. BUG=334544 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245487

Patch Set 1 : #

Patch Set 2 : Revert SearchOperationTest and rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -490 lines) Patch
M chrome/browser/drive/drive_api_util.cc View 2 chunks +26 lines, -3 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.h View 1 3 chunks +16 lines, -15 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 2 32 chunks +295 lines, -472 lines 0 comments Download
M google_apis/drive/drive_api_parser.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
Sorry for sending this large CL. This change does not intend to introduce any behavior ...
6 years, 11 months ago (2014-01-15 06:53:32 UTC) #1
hashimoto
Splitted SearchOperationTest part to https://codereview.chromium.org/137533009/ which also includes a fix for browser_tests. Also, https://codereview.chromium.org/139153003/ should ...
6 years, 11 months ago (2014-01-16 08:25:05 UTC) #2
kinaba
lgtm assuming all the tests indeed pass.
6 years, 11 months ago (2014-01-17 04:52:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/135643005/360001
6 years, 11 months ago (2014-01-17 07:39:50 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 10:27:47 UTC) #5
Message was sent while issue was closed.
Change committed as 245487

Powered by Google App Engine
This is Rietveld 408576698