Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: fpdfsdk/include/javascript/JS_Define.h

Issue 1356373003: Fix a bunch of sign mismatch warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/include/javascript/JS_Define.h
diff --git a/fpdfsdk/include/javascript/JS_Define.h b/fpdfsdk/include/javascript/JS_Define.h
index 04f5eceef5cf298b2086619094e29aacd5ddbcdb..0b5469070070f3d7a2eb575b502114dc836e8f4d 100644
--- a/fpdfsdk/include/javascript/JS_Define.h
+++ b/fpdfsdk/include/javascript/JS_Define.h
@@ -226,12 +226,12 @@ void JSMethod(const char* method_name_string,
FXJSOBJTYPE eObjType) { \
int nObjDefnID = FXJS_DefineObj(pIsolate, js_class_name::m_pClassName, \
eObjType, JSConstructor, JSDestructor); \
- for (int i = 0; i < FX_ArraySize(JS_Class_Properties) - 1; ++i) { \
+ for (size_t i = 0; i < FX_ArraySize(JS_Class_Properties) - 1; ++i) { \
FXJS_DefineObjProperty( \
pIsolate, nObjDefnID, JS_Class_Properties[i].pName, \
JS_Class_Properties[i].pPropGet, JS_Class_Properties[i].pPropPut); \
} \
- for (int i = 0; i < FX_ArraySize(JS_Class_Methods) - 1; ++i) { \
+ for (size_t i = 0; i < FX_ArraySize(JS_Class_Methods) - 1; ++i) { \
FXJS_DefineObjMethod(pIsolate, nObjDefnID, JS_Class_Methods[i].pName, \
JS_Class_Methods[i].pMethodCall); \
} \
@@ -254,7 +254,7 @@ void JSMethod(const char* method_name_string,
FXJSOBJTYPE eObjType) { \
int nObjDefnID = FXJS_DefineObj(pIsolate, js_class_name::m_pClassName, \
eObjType, NULL, NULL); \
- for (int i = 0; i < FX_ArraySize(JS_Class_Consts) - 1; ++i) { \
+ for (size_t i = 0; i < FX_ArraySize(JS_Class_Consts) - 1; ++i) { \
FXJS_DefineObjConst( \
pIsolate, nObjDefnID, JS_Class_Consts[i].pName, \
JS_Class_Consts[i].t == 0 \
@@ -426,13 +426,13 @@ void JSSpecialPropDel(const char* class_name,
FXJSOBJTYPE eObjType) { \
int nObjDefnID = FXJS_DefineObj(pIsolate, js_class_name::m_pClassName, \
eObjType, JSConstructor, JSDestructor); \
- for (int i = 0; i < FX_ArraySize(JS_Class_Properties) - 1; ++i) { \
+ for (size_t i = 0; i < FX_ArraySize(JS_Class_Properties) - 1; ++i) { \
FXJS_DefineObjProperty( \
pIsolate, nObjDefnID, JS_Class_Properties[i].pName, \
JS_Class_Properties[i].pPropGet, JS_Class_Properties[i].pPropPut); \
} \
\
- for (int i = 0; i < FX_ArraySize(JS_Class_Methods) - 1; ++i) { \
+ for (size_t i = 0; i < FX_ArraySize(JS_Class_Methods) - 1; ++i) { \
FXJS_DefineObjMethod(pIsolate, nObjDefnID, JS_Class_Methods[i].pName, \
JS_Class_Methods[i].pMethodCall); \
} \
@@ -493,7 +493,7 @@ void JSGlobalFunc(const char* func_name_string,
#define IMPLEMENT_JS_STATIC_GLOBAL_FUN(js_class_name) \
void js_class_name::DefineJSObjects(v8::Isolate* pIsolate) { \
- for (int i = 0; i < FX_ArraySize(global_methods) - 1; ++i) { \
+ for (size_t i = 0; i < FX_ArraySize(global_methods) - 1; ++i) { \
FXJS_DefineGlobalMethod(pIsolate, \
js_class_name::global_methods[i].pName, \
js_class_name::global_methods[i].pMethodCall); \
« core/src/fpdfapi/fpdf_font/fpdf_font.cpp ('K') | « core/src/fxge/ge/fx_ge_linux.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698