Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1356373003: Fix a bunch of sign mismatch warnings. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a bunch of sign mismatch warnings. Also remove some gotos and move code into an anonymous namespace. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d03ba8d1a5928e8f3f6bd7da063b53b0bc40abfd

Patch Set 1 #

Total comments: 3

Patch Set 2 : enum #

Patch Set 3 : Move more code into anonymous namespace #

Patch Set 4 : Use enum in more places #

Patch Set 5 : rebase #

Patch Set 6 : rebase, resolve conflicts #

Patch Set 7 : rebase again #

Patch Set 8 : fix a couple more trivial comparison warnings... maybe they got lost in the merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+811 lines, -685 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 1 2 4 chunks +12 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 1 2 8 chunks +21 lines, -21 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 2 3 19 chunks +697 lines, -572 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 2 2 chunks +9 lines, -7 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp View 1 2 3 4 5 1 chunk +22 lines, -25 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp View 1 2 3 4 5 6 7 6 chunks +21 lines, -22 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Lei Zhang
5 years, 3 months ago (2015-09-25 05:44:03 UTC) #2
Tom Sepez
https://codereview.chromium.org/1356373003/diff/1/core/include/fpdfapi/fpdf_resource.h File core/include/fpdfapi/fpdf_resource.h (right): https://codereview.chromium.org/1356373003/diff/1/core/include/fpdfapi/fpdf_resource.h#newcode470 core/include/fpdfapi/fpdf_resource.h:470: size_t m_Charset; Can we make this an enum? CS ...
5 years, 2 months ago (2015-09-25 16:06:37 UTC) #3
Lei Zhang
All comments addressed, with a lot more churn.
5 years, 2 months ago (2015-09-25 21:46:58 UTC) #4
Tom Sepez
lgtm
5 years, 2 months ago (2015-10-08 18:51:06 UTC) #5
Lei Zhang
Committed patchset #8 (id:140001) manually as d03ba8d1a5928e8f3f6bd7da063b53b0bc40abfd (presubmit successful).
5 years, 2 months ago (2015-10-08 22:51:33 UTC) #6
Tom Sepez
On 2015/10/08 22:51:33, Lei Zhang wrote: > Committed patchset #8 (id:140001) manually as > d03ba8d1a5928e8f3f6bd7da063b53b0bc40abfd ...
5 years, 2 months ago (2015-10-16 21:38:01 UTC) #7
Lei Zhang
5 years, 2 months ago (2015-10-16 21:38:45 UTC) #8
Message was sent while issue was closed. 
On 2015/10/16 21:38:01, Tom Sepez wrote:
> On 2015/10/08 22:51:33, Lei Zhang wrote:
> > Committed patchset #8 (id:140001) manually as
> > d03ba8d1a5928e8f3f6bd7da063b53b0bc40abfd (presubmit successful).
> 
> Looks like this never made it to XFA based on some diffs I'm seeing. Can you
> please investigate?

Ya, it's on the TODO list. Will merge shortly.

Powered by Google App Engine
This is Rietveld 408576698