Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 1356363005: Revert of [heap] Add more tasks for parallel compaction (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Add more tasks for parallel compaction (patchset #11 id:200001 of https://codereview.chromium.org/1354383002/ ) Reason for revert: [Sheriff] May have caused this new flake: http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/5412 Original issue's description: > [heap] Add more tasks for parallel compaction > > - We now compute the number of parallel compaction tasks, depending on the > evacuation candidate list, the number of cores, and some hard limit. > - Free memory is moved over to compaction tasks (up to some limit) > - Moving over memory is done by dividing the free list of a given space up among > other free lists. Since this is potentially slow we limit the maximum amount > of moved memory. > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/0e842418835eea85886a06cf37052895bc8a17db > Cr-Commit-Position: refs/heads/master@{#30886} TBR=hpayer@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/bfccd5187ceb21c99feea4538e08ca7aef48b65b Cr-Commit-Position: refs/heads/master@{#30888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -146 lines) Patch
M src/heap/mark-compact.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +14 lines, -26 lines 0 comments Download
M src/heap/spaces.h View 5 chunks +6 lines, -41 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +18 lines, -75 lines 0 comments Download
M test/cctest/test-spaces.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [heap] Add more tasks for parallel compaction
5 years, 3 months ago (2015-09-23 13:46:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356363005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356363005/1
5 years, 3 months ago (2015-09-23 13:46:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 13:46:57 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 13:47:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfccd5187ceb21c99feea4538e08ca7aef48b65b
Cr-Commit-Position: refs/heads/master@{#30888}

Powered by Google App Engine
This is Rietveld 408576698