Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1356363004: Add CompilationInfo::output_code_kind to allow overriding the kind of code generated. (Closed)

Created:
5 years, 3 months ago by titzer
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add CompilationInfo::output_code_kind to allow overriding the kind of code generated. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/8a77673b5208328d0f687e6024a09b1d4d39cfd2 Cr-Commit-Position: refs/heads/master@{#30892}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M src/codegen.cc View 1 1 chunk +9 lines, -10 lines 0 comments Download
M src/compiler.h View 3 chunks +7 lines, -0 lines 0 comments Download
M src/compiler.cc View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 3 months ago (2015-09-23 12:53:57 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1356363004/diff/1/src/codegen.cc File src/codegen.cc (right): https://codereview.chromium.org/1356363004/diff/1/src/codegen.cc#newcode150 src/codegen.cc:150: info->output_code_kind(), info->code_stub()->GetICState(), nit: Can we DCHECK_EQ(info->output_code_kind(), info->code_stub()->GetCodeKind()) here? ...
5 years, 3 months ago (2015-09-23 13:22:59 UTC) #2
titzer
On 2015/09/23 13:22:59, Michael Starzinger wrote: > LGTM. > > https://codereview.chromium.org/1356363004/diff/1/src/codegen.cc > File src/codegen.cc (right): ...
5 years, 3 months ago (2015-09-23 13:32:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356363004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356363004/20001
5 years, 3 months ago (2015-09-23 13:32:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 14:00:28 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 14:00:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8a77673b5208328d0f687e6024a09b1d4d39cfd2
Cr-Commit-Position: refs/heads/master@{#30892}

Powered by Google App Engine
This is Rietveld 408576698