Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: Source/devtools/front_end/settings/SettingsScreen.js

Issue 1356363002: [DevTools] Remove relativeToElement from Dialog. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 307 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 * @override 318 * @override
319 * @return {!Element} 319 * @return {!Element}
320 */ 320 */
321 settingElement: function() 321 settingElement: function()
322 { 322 {
323 return createTextButton(WebInspector.manageBlackboxingButtonLabel(), thi s._onManageButtonClick.bind(this), "", WebInspector.UIString("Skip stepping thro ugh sources with particular names")); 323 return createTextButton(WebInspector.manageBlackboxingButtonLabel(), thi s._onManageButtonClick.bind(this), "", WebInspector.UIString("Skip stepping thro ugh sources with particular names"));
324 }, 324 },
325 325
326 _onManageButtonClick: function() 326 _onManageButtonClick: function()
327 { 327 {
328 WebInspector.FrameworkBlackboxDialog.show(WebInspector.inspectorView.ele ment); 328 WebInspector.FrameworkBlackboxDialog.show();
329 } 329 }
330 } 330 }
331 331
332 /** 332 /**
333 * @constructor 333 * @constructor
334 * @extends {WebInspector.SettingsTab} 334 * @extends {WebInspector.SettingsTab}
335 */ 335 */
336 WebInspector.WorkspaceSettingsTab = function() 336 WebInspector.WorkspaceSettingsTab = function()
337 { 337 {
338 WebInspector.SettingsTab.call(this, WebInspector.UIString("Workspace"), "wor kspace-tab-content"); 338 WebInspector.SettingsTab.call(this, WebInspector.UIString("Workspace"), "wor kspace-tab-content");
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 _editFileSystemClicked: function() 417 _editFileSystemClicked: function()
418 { 418 {
419 this._editFileSystem(this._selectedFileSystemPath()); 419 this._editFileSystem(this._selectedFileSystemPath());
420 }, 420 },
421 421
422 /** 422 /**
423 * @param {?string} id 423 * @param {?string} id
424 */ 424 */
425 _editFileSystem: function(id) 425 _editFileSystem: function(id)
426 { 426 {
427 WebInspector.EditFileSystemDialog.show(WebInspector.inspectorView.elemen t, id); 427 WebInspector.EditFileSystemDialog.show(id);
428 }, 428 },
429 429
430 /** 430 /**
431 * @param {!Element} columnElement 431 * @param {!Element} columnElement
432 * @param {{id: string, placeholder: (string|undefined), options: (!Array.<s tring>|undefined)}} column 432 * @param {{id: string, placeholder: (string|undefined), options: (!Array.<s tring>|undefined)}} column
433 * @param {?string} id 433 * @param {?string} id
434 */ 434 */
435 _renderFileSystem: function(columnElement, column, id) 435 _renderFileSystem: function(columnElement, column, id)
436 { 436 {
437 if (!id) 437 if (!id)
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
1156 var columnId = columns[i]; 1156 var columnId = columns[i];
1157 var editElement = this._addInputElements.get(columnId); 1157 var editElement = this._addInputElements.get(columnId);
1158 this._setEditElementValue(editElement, ""); 1158 this._setEditElementValue(editElement, "");
1159 } 1159 }
1160 }, 1160 },
1161 1161
1162 __proto__: WebInspector.SettingsList.prototype 1162 __proto__: WebInspector.SettingsList.prototype
1163 } 1163 }
1164 1164
1165 WebInspector._settingsController = new WebInspector.SettingsController(); 1165 WebInspector._settingsController = new WebInspector.SettingsController();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698