Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1356363002: [DevTools] Remove relativeToElement from Dialog. (Closed)

Created:
5 years, 2 months ago by dgozman
Modified:
5 years, 2 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Remove relativeToElement from Dialog. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -71 lines) Patch
M Source/devtools/front_end/components_lazy/FilmStripView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/devices/DevicesDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/settings/EditFileSystemDialog.js View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/settings/FrameworkBlackboxDialog.js View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/devtools/front_end/settings/SettingsScreen.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/source_frame/GoToLineDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/AddSourceMapURLDialog.js View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sources/FilteredItemSelectionDialog.js View 5 chunks +13 lines, -17 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesView.js View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sources/StyleSheetOutlineDialog.js View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Dialog.js View 4 chunks +9 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Take a look please.
5 years, 2 months ago (2015-09-22 19:07:50 UTC) #2
pfeldman
lgtm
5 years, 2 months ago (2015-09-22 23:48:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356363002/1
5 years, 2 months ago (2015-09-23 00:06:56 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 05:50:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202664

Powered by Google App Engine
This is Rietveld 408576698