OLD | NEW |
(Empty) | |
| 1 # How to get an LSS change committed |
| 2 |
| 3 ## Review |
| 4 |
| 5 You get your change reviewed, you can upload it to |
| 6 http://codereview.chromium.org (Rietveld) using `git cl upload` from Chromium's |
| 7 `depot-tools`. |
| 8 |
| 9 ## Testing |
| 10 |
| 11 Unfortunately, LSS has no automated test suite. |
| 12 |
| 13 You can test LSS by patching it into Chromium, building Chromium, and running |
| 14 Chromium's tests. (See [ProjectsUsingLSS](projects_using_lss.md).) |
| 15 |
| 16 You can compile-test LSS by running: |
| 17 |
| 18 gcc -Wall -Wextra -Wstrict-prototypes -c linux_syscall_support.h |
| 19 |
| 20 ## Rolling into Chromium |
| 21 |
| 22 If you commit a change to LSS, please also commit a Chromium change to update |
| 23 `lss_revision` in Chromium's DEPS file. |
| 24 |
| 25 This ensures that the LSS change gets tested, so that people who commit later |
| 26 LSS changes don't run into problems with updating `lss_revision`. |
OLD | NEW |