Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1356223004: Move heap and CPU profilers into a dedicated directory. (Closed)

Created:
5 years, 3 months ago by alph
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move heap and CPU profilers into a dedicated directory. Drive-by: remove unnecessary includes. Committed: https://crrev.com/e0606c9f005aff1a5d5193d06603fa4766a7b3bb Cr-Commit-Position: refs/heads/master@{#30987}

Patch Set 1 #

Patch Set 2 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -8077 lines) Patch
M BUILD.gn View 1 7 chunks +19 lines, -19 lines 0 comments Download
D src/allocation-tracker.h View 1 chunk +0 lines, -157 lines 0 comments Download
D src/allocation-tracker.cc View 1 1 chunk +0 lines, -340 lines 0 comments Download
M src/api.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
D src/circular-queue.h View 1 chunk +0 lines, -68 lines 0 comments Download
D src/circular-queue-inl.h View 1 chunk +0 lines, -69 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D src/cpu-profiler.h View 1 chunk +0 lines, -276 lines 0 comments Download
D src/cpu-profiler.cc View 1 chunk +0 lines, -531 lines 0 comments Download
D src/cpu-profiler-inl.h View 1 chunk +0 lines, -79 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
D src/heap-profiler.h View 1 chunk +0 lines, -84 lines 0 comments Download
D src/heap-profiler.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D src/heap-snapshot-generator.h View 1 chunk +0 lines, -621 lines 0 comments Download
D src/heap-snapshot-generator.cc View 1 chunk +0 lines, -3181 lines 0 comments Download
D src/heap-snapshot-generator-inl.h View 1 chunk +0 lines, -48 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/heap-inl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/scavenger.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/log.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D src/profile-generator.h View 1 chunk +0 lines, -388 lines 0 comments Download
D src/profile-generator.cc View 1 1 chunk +0 lines, -705 lines 0 comments Download
D src/profile-generator-inl.h View 1 chunk +0 lines, -48 lines 0 comments Download
A + src/profiler/allocation-tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/profiler/allocation-tracker.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + src/profiler/circular-queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/profiler/circular-queue-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/profiler/cpu-profiler.h View 2 chunks +6 lines, -6 lines 0 comments Download
A + src/profiler/cpu-profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + src/profiler/cpu-profiler-inl.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + src/profiler/heap-profiler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/profiler/heap-profiler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + src/profiler/heap-snapshot-generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/profiler/heap-snapshot-generator.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + src/profiler/heap-snapshot-generator-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/profiler/profile-generator.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/profiler/profile-generator.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + src/profiler/profile-generator-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + src/profiler/sampler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/profiler/sampler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/profiler/unbound-queue.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + src/profiler/unbound-queue-inl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/regexp/arm/regexp-macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/arm64/regexp-macro-assembler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/ppc/regexp-macro-assembler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/x64/regexp-macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/x87/regexp-macro-assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D src/sampler.h View 1 chunk +0 lines, -135 lines 0 comments Download
D src/sampler.cc View 1 chunk +0 lines, -858 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D src/unbound-queue.h View 1 chunk +0 lines, -47 lines 0 comments Download
D src/unbound-queue-inl.h View 1 chunk +0 lines, -82 lines 0 comments Download
M src/v8.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-api.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-circular-queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-profile-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-unbound-queue.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/trace-extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 7 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356223004/1
5 years, 3 months ago (2015-09-22 18:25:52 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-22 20:47:23 UTC) #4
alph
ptal
5 years, 3 months ago (2015-09-22 20:48:40 UTC) #6
yurys
lgtm
5 years, 3 months ago (2015-09-22 20:51:34 UTC) #7
Yang
On 2015/09/22 20:51:34, yurys wrote: > lgtm regexp subfolder lgtm
5 years, 3 months ago (2015-09-22 21:00:28 UTC) #8
Yang
On 2015/09/22 21:00:28, Yang OOO until mid October wrote: > On 2015/09/22 20:51:34, yurys wrote: ...
5 years, 3 months ago (2015-09-22 21:01:31 UTC) #9
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-25 10:52:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356223004/1
5 years, 2 months ago (2015-09-25 14:50:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6097)
5 years, 2 months ago (2015-09-25 15:01:05 UTC) #15
alph
Benedikt, could you please take a look at: compiler debug full-codegen ic Thanks.
5 years, 2 months ago (2015-09-25 15:04:24 UTC) #16
Benedikt Meurer
LGTM from my side.
5 years, 2 months ago (2015-09-28 17:29:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356223004/20001
5 years, 2 months ago (2015-09-28 18:35:03 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 19:34:18 UTC) #22
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:34:37 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0606c9f005aff1a5d5193d06603fa4766a7b3bb
Cr-Commit-Position: refs/heads/master@{#30987}

Powered by Google App Engine
This is Rietveld 408576698