Issue 1356223003: Revert of Fix for degenerate stroke rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1356223003: Revert of Fix for degenerate stroke rect (Closed)

Created:
5 years, 3 months ago by joshualitt

Modified:
5 years, 3 months ago

Reviewers:
robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Fix for degenerate stroke rect (patchset #7 id:110001 of https://codereview.chromium.org/1359453002/ ) Reason for revert: breaking bots Original issue's description: > Fix for degenerate stroke rect > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/511684fb52f20862f8552f5009390ff3987b08d8 TBR=robertphillips@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/a204ceda21f3c5a319d44de4bd32eb47e4e123e1

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -113 lines)			Patch
M	src/gpu/batches/GrAAStrokeRectBatch.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/gpu/batches/GrAAStrokeRectBatch.cpp	View	16 chunks	+36 lines, -90 lines	0 comments	Download
M	src/gpu/batches/GrRectBatchFactory.cpp	View	4 chunks	+17 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356223003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356223003/1

5 years, 3 months ago (2015-09-22 16:47:51 UTC) #2

commit-bot: I haz the power

5 years, 3 months ago (2015-09-22 16:48:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a204ceda21f3c5a319d44de4bd32eb47e4e123e1

Expand Messages | Collapse Messages