Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1356173002: Removing deprecated environments from App Remoting build files. (Closed)

Created:
5 years, 3 months ago by joedow
Modified:
5 years, 3 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing deprecated environments from App Remoting build files. BUG= Committed: https://crrev.com/1c4ddaf37732b27951123f54a35c0cd52e8d108b Cr-Commit-Position: refs/heads/master@{#350064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M remoting/remoting_options.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_options.gypi View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/build-webapp.py View 5 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joedow
PTAL!
5 years, 3 months ago (2015-09-21 19:58:17 UTC) #2
garykac
lgtm
5 years, 3 months ago (2015-09-21 23:12:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356173002/1
5 years, 3 months ago (2015-09-21 23:27:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 23:40:26 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 23:42:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c4ddaf37732b27951123f54a35c0cd52e8d108b
Cr-Commit-Position: refs/heads/master@{#350064}

Powered by Google App Engine
This is Rietveld 408576698