Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1356133002: Combined approach. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Combined approach. This combines some ideas from these two CLs: - try stosd/w - update memset16/32 inlining heuristics BUG=skia:4316 Blinking in and out for perf.skia.org. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/46243a7c02a1d5116e55a27ff59218f9c320df97 Possible that MSAN doesn't understand rep sto, or that there's a bug here: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/4178/steps/cc_unittests/logs/IntersectingQuadPixelTest_1.RenderPassQuads

Patch Set 1 #

Patch Set 2 : value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M include/core/SkUtils.h View 1 4 chunks +29 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356133002/1
5 years, 3 months ago (2015-09-21 17:45:05 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3276) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 3 months ago (2015-09-21 17:45:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356133002/20001
5 years, 3 months ago (2015-09-21 17:46:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356133002/20001
5 years, 3 months ago (2015-09-21 17:50:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/46243a7c02a1d5116e55a27ff59218f9c320df97
5 years, 3 months ago (2015-09-21 17:50:59 UTC) #10
mtklein
5 years, 3 months ago (2015-09-21 18:02:22 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1353703006/ by mtklein@google.com.

The reason for reverting is: whee.

Powered by Google App Engine
This is Rietveld 408576698