Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 13561007: A new Makefile for the Native Client V8 builds. (Closed)

Created:
7 years, 8 months ago by Brad Chen
Modified:
7 years, 8 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

A new Makefile for the Native Client V8 builds. This was derived from Makefile.android BUG=v8:2614 Committed: http://code.google.com/p/v8/source/detail?r=14176

Patch Set 1 #

Patch Set 2 : Re-enabling v8 snapshot #

Patch Set 3 : Minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -43 lines) Patch
A + Makefile.nacl View 1 2 2 chunks +41 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Brad Chen
PTAL
7 years, 8 months ago (2013-04-04 18:12:51 UTC) #1
Jakob Kummerow
LGTM. I'll land this.
7 years, 8 months ago (2013-04-09 08:19:45 UTC) #2
Jakob Kummerow
7 years, 8 months ago (2013-04-09 08:25:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r14176 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698