Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1356053002: Consider Layout tree cycles when resolving the <pattern> content element (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
pdr., f(malita), fmalita1
CC:
blink-reviews, blink-reviews-layout_chromium.org, krit, eae+blinkwatch, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Consider Layout tree cycles when resolving the <pattern> content element When SVGPatternElement determines the attributes of a pattern, it will not factor in any cycles brought upon it by the actual content elements. The cycle solver however does this analysis when it is run on a resource. To bridge this DOM vs. Layout tree "gap", make sure to inspect the chain of linked resources when determining the content element to use when generating the pattern data. BUG=104448 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202631

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
A LayoutTests/svg/custom/pattern-content-inheritance-cycle.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/pattern-content-inheritance-cycle-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePattern.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGResourcePattern.cpp View 3 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
fs
Optionally, we could move SVGPatternElement::collectPatternAttributes to the layout tree side and then walk the chain ...
5 years, 3 months ago (2015-09-21 13:02:38 UTC) #2
f(malita)
On 2015/09/21 13:02:38, fs wrote: > Optionally, we could move SVGPatternElement::collectPatternAttributes to the > layout ...
5 years, 3 months ago (2015-09-21 17:01:25 UTC) #3
fs
On 2015/09/21 at 17:01:25, fmalita wrote: > On 2015/09/21 13:02:38, fs wrote: > > Optionally, ...
5 years, 3 months ago (2015-09-21 17:43:14 UTC) #4
fmalita1
SGTM/LGTM
5 years, 3 months ago (2015-09-22 13:34:22 UTC) #6
fs
On 2015/09/22 at 13:34:22, fmalita wrote: > SGTM/LGTM Sorry, but I think managed to rant ...
5 years, 3 months ago (2015-09-22 13:48:40 UTC) #7
f(malita)
On 2015/09/22 13:48:40, fs wrote: > On 2015/09/22 at 13:34:22, fmalita wrote: > > SGTM/LGTM ...
5 years, 3 months ago (2015-09-22 13:55:48 UTC) #8
fs
On 2015/09/22 at 13:55:48, fmalita wrote: > On 2015/09/22 13:48:40, fs wrote: > > On ...
5 years, 3 months ago (2015-09-22 14:12:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1356053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1356053002/1
5 years, 3 months ago (2015-09-22 14:12:49 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 15:25:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202631

Powered by Google App Engine
This is Rietveld 408576698