Mac: Support 10.10's -[NSViewController viewDidLoad] for BookmarkBarController

base/mac/sdk_forward_declarations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains forward declarations for items in later SDKs than the
 // default one with which Chromium is built (currently 10.6).
 // If you call any function from this header, be sure to check at runtime for
 // respondsToSelector: before calling these functions (else your code will crash
 // on older OS X versions that chrome still supports).
 
@@ skipping 473 matching lines @@
 - (instancetype)initWithActivityType:(NSString*)activityType;
 - (void)becomeCurrent;
 - (void)invalidate;
 
 @end
 
 @interface CBUUID (YosemiteSDK)
 - (NSString*)UUIDString;
 @end
 
+@interface NSViewController (YosemiteSDK)

[Robert Sesek, 2015/09/21 22:04:01]

We build with the 10.10 SDK now, so is this necessary?

[tapted, 2015/09/21 23:55:16]

Yup. It was silent on my checkout still linking to 10.9, but it will get a
partial availability warning when linking against 10.10 or later - 

../../chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:257:9: error:
'viewDidLoad' is partial: introduced in OS X 10.10
[-Werror,-Wpartial-availability]
  [self viewDidLoad];
        ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSViewController.h:103:1:
note: 'viewDidLoad' has been explicitly marked partial here
- (void)viewDidLoad NS_AVAILABLE_MAC(10_10);
^
../../chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:257:9: note:
explicitly redeclare 'viewDidLoad' to silence this warning
  [self viewDidLoad];

+- (void)viewDidLoad;
+@end
+
 #endif  // MAC_OS_X_VERSION_10_10
 
 // ----------------------------------------------------------------------------
 // Chrome uses -[CWNetwork securityMode] and -[CWNetwork rssi] on OSX 10.6. The
 // former method relies on the enum CWSecurityMode which was removed in the OSX
 // 10.9 SDK. In order for Chrome to compile against an OSX 10.9+ SDK, Chrome
 // must define this enum. Chrome must also declare these methods.
 //
 // These declarations and definitions will not be necessary once Chrome no
 // longer runs on OSX 10.6.
@@ skipping 21 matching lines @@
 // The symbol for kCWSSIDDidChangeNotification is available in the
 // CoreWLAN.framework for OSX versions 10.6 through 10.10. The symbol is not
 // declared in the OSX 10.9+ SDK, so when compiling against an OSX 10.9+ SDK,
 // declare the symbol.
 // ----------------------------------------------------------------------------
 #if defined(MAC_OS_X_VERSION_10_9) && \
     MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_9
 BASE_EXPORT extern "C" NSString* const kCWSSIDDidChangeNotification;
 #endif
 #endif  // BASE_MAC_SDK_FORWARD_DECLARATIONS_H_