Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: src/platform-linux.cc

Issue 13560007: Remove ARM support for soft float (pre-VFP2) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: tweaks Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform-linux.cc
diff --git a/src/platform-linux.cc b/src/platform-linux.cc
index 1f9cde151c13f554a108a4b90b74573187808cdd..e1bcb6bf9186f8df2c8f6b19f43f271a56c3a31d 100644
--- a/src/platform-linux.cc
+++ b/src/platform-linux.cc
@@ -146,9 +146,6 @@ bool OS::ArmCpuHasFeature(CpuFeature feature) {
// facility is universally available on the ARM architectures,
// so it's up to individual OSes to provide such.
switch (feature) {
- case VFP2:
- search_string = "vfp";
- break;
case VFP3:
search_string = "vfpv3";
break;
@@ -1278,6 +1275,7 @@ void OS::SetUp() {
#ifdef __arm__
// When running on ARM hardware check that the EABI used by V8 and
// by the C code is the same.
+ ASSERT(FLAG_enable_vfp2); // As of 3.18, VFP2 is required for V8
bool hard_float = OS::ArmUsingHardFloat();
if (hard_float) {
#if !USE_EABI_HARDFLOAT
« src/flag-definitions.h ('K') | « src/mips/lithium-mips.cc ('k') | src/v8globals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698