Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: ui/message_center/views/notification_view.cc

Issue 13560002: Added padding below text in notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/message_center/views/notification_view.cc
diff --git a/ui/message_center/views/notification_view.cc b/ui/message_center/views/notification_view.cc
index 65e8aee9b08204c5c7e39777c84957c2608f1944..179ac3ac32b5edfe6a79bd3986486349b662ae25 100644
--- a/ui/message_center/views/notification_view.cc
+++ b/ui/message_center/views/notification_view.cc
@@ -32,8 +32,8 @@ namespace {
const int kIconColumnWidth = message_center::kNotificationIconSize;
const int kLegacyIconSize = 40;
const int kTextLeftPadding = kIconColumnWidth +
- message_center::kIconToTextPadding;
-const int kTextBottomPadding = 6;
+ message_center::kIconToTextPadding;
+const int kTextBottomPadding = 12;
const int kTextRightPadding = 23;
const int kItemTitleToMessagePadding = 3;
const int kButtonHeight = 38;
@@ -363,6 +363,9 @@ NotificationView::NotificationView(const Notification& notification,
// at the top of the notification (to the right of the icon) except for the
// close button.
top_view_ = new ContainerView();
+ top_view_->set_border(MakeBorder(kTextTopPadding - 5,
+ kTextBottomPadding - 4,
+ 0, 0));
// Create the title view if appropriate.
title_view_ = NULL;
@@ -377,7 +380,7 @@ NotificationView::NotificationView(const Notification& notification,
title_view_->SetFont(title_view_->font().DeriveFont(2));
title_view_->SetEnabledColor(message_center::kRegularTextColor);
title_view_->SetBackgroundColor(kRegularTextBackgroundColor);
- title_view_->set_border(MakeBorder(kTextTopPadding, 3));
+ title_view_->set_border(MakeBorder(0, 0));
msw 2013/04/04 18:44:50 nit: this seems unnecessary now.
top_view_->AddChildView(title_view_);
}
@@ -395,7 +398,7 @@ NotificationView::NotificationView(const Notification& notification,
message_view_->SetElideBehavior(views::Label::ELIDE_AT_END);
message_view_->SetEnabledColor(message_center::kRegularTextColor);
message_view_->SetBackgroundColor(kRegularTextBackgroundColor);
- message_view_->set_border(MakeBorder(0, 3));
+ message_view_->set_border(MakeBorder(1, 0));
top_view_->AddChildView(message_view_);
}
@@ -404,7 +407,7 @@ NotificationView::NotificationView(const Notification& notification,
for (size_t i = 0; i < items.size() && i < kNotificationMaximumItems; ++i) {
ItemView* item_view = new ItemView(items[i]);
item_view->SetVisible(is_expanded());
- item_view->set_border(MakeBorder(0, 4));
+ item_view->set_border(MakeBorder(1, 0));
item_views_.push_back(item_view);
top_view_->AddChildView(item_view);
}

Powered by Google App Engine
This is Rietveld 408576698