Chromium Code Reviews| Index: ui/message_center/cocoa/notification_controller.mm |
| diff --git a/ui/message_center/cocoa/notification_controller.mm b/ui/message_center/cocoa/notification_controller.mm |
| index d3e8c77799b5afe47dfe8ce64174e925d4dccf5e..23f61a567105553998902159827b78da607cab0d 100644 |
| --- a/ui/message_center/cocoa/notification_controller.mm |
| +++ b/ui/message_center/cocoa/notification_controller.mm |
| @@ -14,6 +14,12 @@ |
| #include "ui/message_center/notification.h" |
| #include "ui/message_center/notification_change_observer.h" |
| +namespace { |
| + |
| +const int kTextTopPaddingAdjustment = -6; |
| + // Compensates for padding already provided by UI elements involved. |
|
Robert Sesek
2013/04/08 21:15:19
Should go above the constant without any indentati
dharcourt
2013/04/08 21:30:27
Done.
|
| + |
| +} // namespace |
| @interface MCNotificationController (Private) |
| // Configures a NSBox to be borderless, titleless, and otherwise appearance- |
| // free. |
| @@ -79,9 +85,11 @@ |
| // In this basic notification UI, the message body is the bottom-most |
| // vertical element. If it is out of the rootView's bounds, resize the view. |
| - if (NSMinY([message_ frame]) < message_center::kTextTopPadding) { |
| - rootFrame.size.height += message_center::kTextTopPadding - |
| - NSMinY([message_ frame]); |
| + if (NSMinY([message_ frame]) < |
| + message_center::kTextTopPadding + kTextTopPaddingAdjustment) { |
|
Robert Sesek
2013/04/08 21:15:19
nit: indent 4 spaces since this is a continuation
dharcourt
2013/04/08 21:30:27
Done.
|
| + rootFrame.size.height += message_center::kTextTopPadding + |
| + kTextTopPaddingAdjustment - |
| + NSMinY([message_ frame]); |
| } |
| [rootView setFrame:rootFrame]; |
| @@ -159,7 +167,8 @@ |
| CGFloat delta = |
| [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:title_]; |
| frame.size.height = delta; |
| - frame.origin.y = NSMaxY(rootFrame) - message_center::kTextTopPadding - delta; |
| + frame.origin.y = NSMaxY(rootFrame) - message_center::kTextTopPadding + |
| + kTextTopPaddingAdjustment - delta; |
| [title_ setFrame:frame]; |
| } |
| @@ -175,7 +184,8 @@ |
| CGFloat delta = |
| [GTMUILocalizerAndLayoutTweaker sizeToFitFixedWidthTextField:message_]; |
| frame.size.height = delta; |
| - frame.origin.y = maxY - message_center::kTextTopPadding - delta; |
| + frame.origin.y = maxY - message_center::kTextTopPadding + |
| + kTextTopPaddingAdjustment - delta; |
| [message_ setFrame:frame]; |
| } |