Issue 1355993002: Cleanup: Pass std::string as const reference from native_client_sdk/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1355993002: Cleanup: Pass std::string as const reference from native_client_sdk/ (Closed)

Created:
5 years, 3 months ago by ki.stfu

Modified:
5 years, 3 months ago

Reviewers:
noelallen1, binji, Sam Clegg

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: Pass std::string as const reference from native_client_sdk/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=binji@chromium.org,noelallen@chromium.org Committed: https://crrev.com/42d17b85eb1823d17cddb8c027847207a28a336b Cr-Commit-Position: refs/heads/master@{#349917}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	native_client_sdk/src/examples/api/file_io/file_io.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355993002/1

5 years, 3 months ago (2015-09-21 09:10:45 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-21 09:20:21 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/42d17b85eb1823d17cddb8c027847207a28a336b
Cr-Commit-Position: refs/heads/master@{#349917}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages