Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1355983003: X87: [stubs] Refactor StringCompareStub and use it for HStringCompareAndBranch. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Refactor StringCompareStub and use it for HStringCompareAndBranch. port 8016547c8e6fde00fff0a1791f3c83b444d8af25 (r30818). original commit message: The StringCompareStub used to take its parameters on the (JavaScript) stack, which made it impossible to use in TurboFan. Actually StringCompareStub was currently completely unused. This changes the calling convention to something TurboFan compatible and introduces a CallInterfaceDescriptor for StringCompareStub. It also changes HStringCompareAndBranch to use the StringCompareStub instead of using the full blown CompareICStub for a stupid string comparison. BUG= Committed: https://crrev.com/be04dd5c9e6023cc4114bd41f80fde3201e784e9 Cr-Commit-Position: refs/heads/master@{#30845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +14 lines, -16 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-21 02:25:39 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-21 08:50:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355983003/1
5 years, 3 months ago (2015-09-21 08:50:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 09:18:15 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 09:18:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be04dd5c9e6023cc4114bd41f80fde3201e784e9
Cr-Commit-Position: refs/heads/master@{#30845}

Powered by Google App Engine
This is Rietveld 408576698