components/user_manager/user_manager_base.cc - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_manager/user_manager_base.cc

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/user_manager/user_manager_base.h ('k') | components/user_prefs/tracked/tracked_preferences_migration_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/user_manager/user_manager_base.cc

diff --git a/components/user_manager/user_manager_base.cc b/components/user_manager/user_manager_base.cc

index 4dcf5212ab23fb3a3d379221e688d1ccff452fe4..3eee72a9ee14d90c299a59527a2c76d6c278b65c 100644

--- a/components/user_manager/user_manager_base.cc

+++ b/components/user_manager/user_manager_base.cc

@@ -790,7 +790,7 @@ bool UserManagerBase::HasPendingBootstrap(const std::string& user_id) const {

return false;

}

-void UserManagerBase::SetOwnerEmail(std::string owner_user_id) {

+void UserManagerBase::SetOwnerEmail(const std::string& owner_user_id) {

owner_email_ = owner_user_id;

}

@@ -798,7 +798,7 @@ const std::string& UserManagerBase::GetPendingUserSwitchID() const {

return pending_user_switch_;

}

-void UserManagerBase::SetPendingUserSwitchID(std::string user_id) {

+void UserManagerBase::SetPendingUserSwitchID(const std::string& user_id) {

pending_user_switch_ = user_id;

}