components/sync_driver/tab_node_pool.cc - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/tab_node_pool.cc

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/sync_driver/tab_node_pool.cc

diff --git a/components/sync_driver/tab_node_pool.cc b/components/sync_driver/tab_node_pool.cc

index e3f611961fef497d33087e7374aaf7fc17cf50f4..ee6278ca4a296bf372a1cc1588fbdf0a6393fb8c 100644

--- a/components/sync_driver/tab_node_pool.cc

+++ b/components/sync_driver/tab_node_pool.cc

@@ -28,8 +28,8 @@ const int TabNodePool::kInvalidTabNodeID = -1;

TabNodePool::~TabNodePool() {}

// Static

-std::string TabNodePool::TabIdToTag(

- const std::string machine_tag, int tab_node_id) {

+std::string TabNodePool::TabIdToTag(const std::string& machine_tag,

+ int tab_node_id) {

return base::StringPrintf("%s %d", machine_tag.c_str(), tab_node_id);

}

« no previous file with comments | « components/sync_driver/tab_node_pool.h ('k') | components/test_runner/test_runner.h » ('j') | no next file with comments »