components/sync_driver/device_info.cc - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info.cc

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/sync_driver/device_info.cc

diff --git a/components/sync_driver/device_info.cc b/components/sync_driver/device_info.cc

index c80a1571c964640a6c00ea74fe10939a90f6275c..b645ca9f433ffd83ae179150e8747dfa6b24b1c3 100644

--- a/components/sync_driver/device_info.cc

+++ b/components/sync_driver/device_info.cc

@@ -106,7 +106,7 @@ base::DictionaryValue* DeviceInfo::ToValue() {

return value;

}

-void DeviceInfo::set_public_id(std::string id) {

+void DeviceInfo::set_public_id(const std::string& id) {

public_id_ = id;

}

« no previous file with comments | « components/sync_driver/device_info.h ('k') | components/sync_driver/tab_node_pool.h » ('j') | no next file with comments »