components/signin/core/browser/about_signin_internals.h - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/about_signin_internals.h

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/template_url_parser_unittest.cc ('k') | components/signin/core/browser/about_signin_internals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/about_signin_internals.h

diff --git a/components/signin/core/browser/about_signin_internals.h b/components/signin/core/browser/about_signin_internals.h

index 55e4de6d5ed73fa26a28b93b4a358037f8e24dbc..7e0dca5974b2d1f37c5beee9cece217dfb540b9b 100644

--- a/components/signin/core/browser/about_signin_internals.h

+++ b/components/signin/core/browser/about_signin_internals.h

@@ -73,8 +73,8 @@ class AboutSigninInternals

void Initialize(SigninClient* client);

- void OnRefreshTokenReceived(std::string status);

- void OnAuthenticationResultReceived(std::string status);

+ void OnRefreshTokenReceived(const std::string& status);

+ void OnAuthenticationResultReceived(const std::string& status);

// KeyedService implementation.

void Shutdown() override;