components/network_hints/renderer/dns_prefetch_queue.h - Issue 1355983002: Cleanup: Pass std::string as const reference from components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/network_hints/renderer/dns_prefetch_queue.h

Issue 1355983002: Cleanup: Pass std::string as const reference from components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to PS2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/cloned_install_detector.cc ('k') | components/password_manager/core/browser/login_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/network_hints/renderer/dns_prefetch_queue.h

diff --git a/components/network_hints/renderer/dns_prefetch_queue.h b/components/network_hints/renderer/dns_prefetch_queue.h

index 72b4fadf162d1fb4e7507df3bd21d8cad5c7c816..7f5ac2f27e6f318521d6619e451226cedfdb7b9c 100644

--- a/components/network_hints/renderer/dns_prefetch_queue.h

+++ b/components/network_hints/renderer/dns_prefetch_queue.h

@@ -63,7 +63,7 @@ class DnsQueue {

// Returns true for success, false for failure (nothing written).

PushResult Push(const char* source, const size_t length);

- PushResult Push(std::string source) {

+ PushResult Push(const std::string& source) {

return Push(source.c_str(), source.length());

}