components/webcrypto/algorithms/aes_cbc_unittest.cc - Issue 1355923002: [refactor] Misc post-NSS WebCrypto cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/webcrypto/algorithms/aes_cbc_unittest.cc

Issue 1355923002: [refactor] Misc post-NSS WebCrypto cleanups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@util_split

Patch Set: add an explicit size_t --> unsigned cast Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/webcrypto/algorithms/aes_cbc_unittest.cc

diff --git a/components/webcrypto/algorithms/aes_cbc_unittest.cc b/components/webcrypto/algorithms/aes_cbc_unittest.cc

index 657c4a4c4325ee5f6c9f1a74464c050f04cff1f3..2aec041799636bcc0f61214ce7c80be9a36ef3b5 100644

--- a/components/webcrypto/algorithms/aes_cbc_unittest.cc

+++ b/components/webcrypto/algorithms/aes_cbc_unittest.cc

@@ -394,7 +394,7 @@ TEST_F(WebCryptoAesCbcTest, ImportExportJwk) {

"A256CBC");

}

-// AES 192-bit is not allowed: http://crbug.com/381829

+// 192-bit AES is intentionally unsupported (http://crbug.com/533699).

TEST_F(WebCryptoAesCbcTest, GenerateAesCbc192) {

blink::WebCryptoKey key;

Status status = GenerateSecretKey(CreateAesCbcKeyGenAlgorithm(192), true,

@@ -402,7 +402,7 @@ TEST_F(WebCryptoAesCbcTest, GenerateAesCbc192) {

ASSERT_EQ(Status::ErrorAes192BitUnsupported(), status);

}

-// AES 192-bit is not allowed: http://crbug.com/381829

+// 192-bit AES is intentionally unsupported (http://crbug.com/533699).

TEST_F(WebCryptoAesCbcTest, UnwrapAesCbc192) {

std::vector<uint8_t> wrapping_key_data(16, 0);

std::vector<uint8_t> wrapped_key = HexStringToBytes(