LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html - Issue 1355913004: Disable newline selection highlighting for vertical and RTL text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html

Issue 1355913004: Disable newline selection highlighting for vertical and RTL text. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@474759_invalidate_br_and_horiz_only

Patch Set: Merge changes. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-rtl-expected.txt ('k') | LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html

diff --git a/LayoutTests/paint/selection/invalidation-rect-includes-newline.html b/LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html

similarity index 65%

copy from LayoutTests/paint/selection/invalidation-rect-includes-newline.html

copy to LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html

index 5fed1477371ba78d2bf051bfb4c9682d8a7330d8..658123ad49a791300d2b5eca3e9376c8aed682b3 100644

--- a/LayoutTests/paint/selection/invalidation-rect-includes-newline.html

+++ b/LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html

@@ -3,7 +3,8 @@

-// Selects two lines and expects a newline to be represented.

+// Selects two lines and expects a newline to *not* be represented as newline

+// highlight selection is currently only enabled for horizontal text.

function repaintTest() {

selectRange(container, 0, container, 1);

};

@@ -12,7 +13,8 @@ window.onload = runRepaintTest;

<style>

div {

font-family: Ahem;

- width: 2em;

+ height: 2em;

+ -webkit-writing-mode: vertical-lr;

}

</style>