Source/core/layout/line/InlineTextBox.cpp - Issue 1355913004: Disable newline selection highlighting for vertical and RTL text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/InlineTextBox.cpp

Issue 1355913004: Disable newline selection highlighting for vertical and RTL text. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@474759_invalidate_br_and_horiz_only

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/paint/selection/text-selection-newline-vertical.html ('k') | Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/line/InlineTextBox.cpp

diff --git a/Source/core/layout/line/InlineTextBox.cpp b/Source/core/layout/line/InlineTextBox.cpp

index 72aa246d7db6e70a1b19d03c0b2e407ea6a7243e..45269b8c41b934c7c70b207457e8c318d5f3cd50 100644

--- a/Source/core/layout/line/InlineTextBox.cpp

+++ b/Source/core/layout/line/InlineTextBox.cpp

@@ -189,6 +189,8 @@ bool InlineTextBox::hasWrappedSelectionNewline() const

{

SelectionState state = selectionState();

return RuntimeEnabledFeatures::selectionPaintingWithoutSelectionGapsEnabled()

+ // TODO(wkorman): Remove horizontal restriction once vertical text is operational.

+ && isHorizontal()

chrishtr 2015/09/18 21:34:28 Only for left-to-right writing mode. RTL is also b

wkorman 2015/09/18 22:15:11 Done.

&& (root().lastSelectedBox() == this)

&& (state == SelectionStart || state == SelectionInside);

}

« no previous file with comments | « LayoutTests/paint/selection/text-selection-newline-vertical.html ('k') | Source/core/paint/InlineTextBoxPainter.cpp » ('j') | no next file with comments »