LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html - Issue 1355913004: Disable newline selection highlighting for vertical and RTL text.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical.html

Issue 1355913004: Disable newline selection highlighting for vertical and RTL text. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@474759_invalidate_br_and_horiz_only

Patch Set: Merge changes. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-rtl-expected.txt ('k') | LayoutTests/paint/selection/invalidation-rect-excludes-newline-for-vertical-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/ahem.js"></script>	2 <script src="../../resources/ahem.js"></script>

3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>	3 <script src="../../fast/repaint/resources/text-based-repaint.js"></script>

4 <script src="resources/selection.js"></script>	4 <script src="resources/selection.js"></script>

5 <script>	5 <script>

6 // Selects two lines and expects a newline to be represented.	6 // Selects two lines and expects a newline to not be represented as newline

	7 // highlight selection is currently only enabled for horizontal text.

7 function repaintTest() {	8 function repaintTest() {

8 selectRange(container, 0, container, 1);	9 selectRange(container, 0, container, 1);

9 };	10 };

10 window.onload = runRepaintTest;	11 window.onload = runRepaintTest;

11 </script>	12 </script>

12 <style>	13 <style>

13 div {	14 div {

14 font-family: Ahem;	15 font-family: Ahem;

15 width: 2em;	16 height: 2em;

	17 -webkit-writing-mode: vertical-lr;

16 }	18 }

17 </style>	19 </style>

18 <div id="container">	20 <div id="container">

19 xx y	21 xx y

20 </div>	22 </div>

OLD	NEW