Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Issue 1355893004: Complete the layered architecture of data_use_measurement component.

Created:
5 years, 3 months ago by amohammadkhan
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@NewArchServices
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete the layered architecture of data_use_measurement component. Currently the data_use_measurement component is not completely layered to be compatible with iOS and its layering is not optimal now. Because, the only usage of //content in the code is to check whether a request is coming from the user or not. It is desired to move DataUseMeasurement class to core and have it take in a a DataUseMeasurementDelegate, which would be an interface defined in the core code with a //content-based implementation in //components/data_use_measurement/content. Currently this interface would have only one method: RequestIsFromUser(net::URLRequest* request). In the future the interface could expand as needed. This organization will set up the code better for sharing with iOS both now and going forward. BUG=527460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -423 lines) Patch
M chrome/browser/net/chrome_network_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate.cc View 1 chunk +4 lines, -2 lines 0 comments Download
D components/data_use_measurement/content/data_use_measurement.h View 1 chunk +0 lines, -99 lines 0 comments Download
D components/data_use_measurement/content/data_use_measurement.cc View 1 chunk +0 lines, -148 lines 0 comments Download
A components/data_use_measurement/content/data_use_measurement_delegate_imp.h View 1 chunk +28 lines, -0 lines 0 comments Download
A components/data_use_measurement/content/data_use_measurement_delegate_imp.cc View 1 chunk +23 lines, -0 lines 0 comments Download
D components/data_use_measurement/content/data_use_measurement_unittest.cc View 1 chunk +0 lines, -151 lines 0 comments Download
A + components/data_use_measurement/core/data_use_measurement.h View 5 chunks +8 lines, -4 lines 0 comments Download
A + components/data_use_measurement/core/data_use_measurement.cc View 2 chunks +9 lines, -15 lines 0 comments Download
A components/data_use_measurement/core/data_use_measurement_delegate.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + components/data_use_measurement/core/data_use_measurement_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698