Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: tool/input_sdk/lib/js/dart2js/js_dart2js.dart

Issue 1355893003: Rewire DDC to use the analyzer task model (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Update pubspec Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/testing.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/input_sdk/lib/js/dart2js/js_dart2js.dart
diff --git a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
index f8e5eed3dccb06da2c10bd7f5cdedad15d909a49..47b52abc35b0252f754a05400a4fe701e44b7994 100644
--- a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
+++ b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart
@@ -189,7 +189,7 @@ class JsObject {
*
* The type of [property] must be either [String] or [num].
*/
- dynamic operator [](property) {
+ dynamic operator [](Object property) {
if (property is! String && property is! num) {
throw new ArgumentError("property is not a String or num");
}
@@ -202,7 +202,7 @@ class JsObject {
*
* The type of [property] must be either [String] or [num].
*/
- operator []=(property, value) {
+ operator []=(Object property, value) {
if (property is! String && property is! num) {
throw new ArgumentError("property is not a String or num");
}
@@ -349,7 +349,7 @@ class JsArray<E> extends JsObject with ListMixin<E> {
// Methods required by ListMixin
- E operator [](index) {
+ E operator [](Object index) {
// TODO(justinfagnani): fix the semantics for non-ints
// dartbug.com/14605
if (index is num && index == index.toInt()) {
@@ -358,7 +358,7 @@ class JsArray<E> extends JsObject with ListMixin<E> {
return super[index];
}
- void operator []=(index, E value) {
+ void operator []=(Object index, E value) {
// TODO(justinfagnani): fix the semantics for non-ints
// dartbug.com/14605
if (index is num && index == index.toInt()) {
@@ -492,7 +492,7 @@ Object _convertToDart(o) {
}
}
-_wrapToDart(o) {
+JsObject _wrapToDart(o) {
if (JS('bool', 'typeof # == "function"', o)) {
return new JsFunction._fromJs(o);
}
« no previous file with comments | « test/testing.dart ('k') | tool/sdk_expected_errors.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698