Rewire DDC to use the analyzer task model

test/checker/checker_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// General type checking tests
 library dev_compiler.test.checker_test;
 
 import 'package:test/test.dart';
 
 import '../testing.dart';
@@ skipping 1354 matching lines @@
             /*severe:InvalidMethodOverride*/A f1; // invalid for getter
             /*severe:InvalidMethodOverride*/C f2; // invalid for setter
             var f3;
             /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/dynamic f4;
           }
        '''
       },
       inferFromOverrides: true);
 
   testChecker(
-      'field/field override 2',
-      {
-        '/main.dart': '''
-          class A {}
-          class B extends A {}
-          class C extends B {}
-
-          class Base {
-            B f1;
-            B f2;
-            B f3;
-            B f4;
-          }
-
-          class Child extends Base {
-            /*severe:InvalidMethodOverride*/A f1; // invalid for getter
-            /*severe:InvalidMethodOverride*/C f2; // invalid for setter
-            /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/var f3;
-            /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/dynamic f4;
-          }
-       '''
-      },
-      inferFromOverrides: false);
-
-  testChecker(
       'getter/getter override',
       {
         '/main.dart': '''
           class A {}
           class B extends A {}
           class C extends B {}
 
           abstract class Base {
             B get f1;
             B get f2;
             B get f3;
             B get f4;
           }
 
           class Child extends Base {
             /*severe:InvalidMethodOverride*/A get f1 => null;
             C get f2 => null;
             get f3 => null;
             /*severe:InvalidMethodOverride*/dynamic get f4 => null;
           }
        '''
       },
       inferFromOverrides: true);
 
   testChecker(
-      'getter/getter override 2',
-      {
-        '/main.dart': '''
-          class A {}
-          class B extends A {}
-          class C extends B {}
-
-          abstract class Base {
-            B get f1;
-            B get f2;
-            B get f3;
-            B get f4;
-          }
-
-          class Child extends Base {
-            /*severe:InvalidMethodOverride*/A get f1 => null;
-            C get f2 => null;
-            /*severe:InvalidMethodOverride*/get f3 => null;
-            /*severe:InvalidMethodOverride*/dynamic get f4 => null;
-          }
-       '''
-      },
-      inferFromOverrides: false);
-
-  testChecker(
       'field/getter override',
       {
         '/main.dart': '''
           class A {}
           class B extends A {}
           class C extends B {}
 
           abstract class Base {
             B f1;
             B f2;
@@ skipping 558 matching lines @@
             }
 
             class I1 {
                 m(B a) {}
             }
 
             class T1 /*severe:InvalidMethodOverride*/extends Base
                 implements I1 {}
 
             class T2 extends Base implements I1 {
-                /*severe:InvalidMethodOverride*/m(a) {}
+                /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/m(a) {}

[Jennifer Messerly, 2015/10/07 21:50:26]

is this an example of a duplicate error message? If so maybe add a TODO
somewhere

[vsm, 2015/10/07 22:02:21]

It's actually now 2 different override errors - one for the method in Base and
one for the method in I1.  The old code only looked at the first override.

             }
 
             class T3 extends Object with /*severe:InvalidMethodOverride*/Base
                 implements I1 {}
 
             class T4 extends Object with Base implements I1 {
-                /*severe:InvalidMethodOverride*/m(a) {}
+                /*severe:InvalidMethodOverride,severe:InvalidMethodOverride*/m(a) {}
             }
          '''
     });
   });
 
   group('class override of grand interface', () {
     testChecker('interface of interface of child', {
       '/main.dart': '''
               class A {}
               class B {}
@@ skipping 426 matching lines @@
               // different.
               // TODO(sigmund): should we merge these as well?
               class T1 /*severe:InvalidMethodOverride*/extends Base
                   with /*severe:InvalidMethodOverride*/M
                   implements I1 {
               }
            '''
     });
   });
 
-  // This is a regression test: we used to report it twice because it was
-  // the top super class and top super interface.
-  // TODO(sigmund): maybe we generalize this and don't report again errors
-  // when an interface is also a superclass.
-  testChecker(
-      'no reporting of overrides with Object twice.',
-      {
-        '/main.dart': '''
-            class A {}
-            class T1 implements A {
-                /*severe:InvalidMethodOverride*/toString() {}
-            }
-         '''
-      },
-      inferFromOverrides: false);
-
   testChecker('invalid runtime checks', {
     '/main.dart': '''
           typedef int I2I(int x);
           typedef int D2I(x);
           typedef int II2I(int x, int y);
           typedef int DI2I(x, int y);
           typedef int ID2I(int x, y);
           typedef int DD2I(x, y);
 
           typedef I2D(int x);
@@ skipping 122 matching lines @@
 
         baz1() sync* { yield* (/*info:DynamicCast*/x); }
         Iterable baz2() sync* { yield* (/*info:DynamicCast*/x); }
         Iterable<int> baz3() sync* { yield* (/*warning:DownCastComposite*/x); }
         Iterable<int> baz4() sync* { yield* new Iterable<int>(); }
         Iterable<int> baz5() sync* { yield* (/*info:InferredTypeAllocation*/new Iterable()); }
     '''
     });
   });
 }