Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1355793003: linux gn config should check use_gconf before looking for it with pkg-config (Closed)

Created:
5 years, 3 months ago by Mostyn Bramley-Moore
Modified:
5 years, 3 months ago
Reviewers:
Chris Masone, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

linux gn config should check use_gconf before looking for it with pkg-config BUG=388412 Committed: https://crrev.com/2f4a32e983d48827ca891bd11aa634e0deae80af Cr-Commit-Position: refs/heads/master@{#349790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/linux/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@brettw, Chris: please take a look. Is it worth renaming use_gconf to use_gnome?
5 years, 3 months ago (2015-09-18 09:07:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355793003/1
5 years, 3 months ago (2015-09-18 09:07:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 09:36:31 UTC) #6
brettw
lgtm
5 years, 3 months ago (2015-09-18 21:22:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1355793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1355793003/1
5 years, 3 months ago (2015-09-18 22:31:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 22:37:56 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 22:38:39 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2f4a32e983d48827ca891bd11aa634e0deae80af
Cr-Commit-Position: refs/heads/master@{#349790}

Powered by Google App Engine
This is Rietveld 408576698