impl/prod/memcache.go - Issue 1355783002: Refactor keys and queries in datastore service and implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/prod/memcache.go

Issue 1355783002: Refactor keys and queries in datastore service and implementation. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: appease errcheck Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/prod/memcache.go

diff --git a/impl/prod/memcache.go b/impl/prod/memcache.go

index eef34b968a6163664e3ba72b1660f4bbe1ec372a..90560b2f0b2ee6f5d9608cde68a85e63606c0637 100644

--- a/impl/prod/memcache.go

+++ b/impl/prod/memcache.go

@@ -141,9 +141,8 @@ func (m mcImpl) CompareAndSwapMulti(items []mc.Item, cb mc.RawCB) error {

func (m mcImpl) Increment(key string, delta int64, initialValue *uint64) (uint64, error) {

if initialValue == nil {

return memcache.IncrementExisting(m.Context, key, delta)

- } else {

- return memcache.Increment(m.Context, key, delta, *initialValue)

}

+ return memcache.Increment(m.Context, key, delta, *initialValue)

}

func (m mcImpl) Flush() error {

« no previous file with comments | « impl/prod/doc.go ('k') | impl/prod/raw_datastore.go » ('j') | no next file with comments »