impl/memory/datastore_index_test.go - Issue 1355783002: Refactor keys and queries in datastore service and implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: impl/memory/datastore_index_test.go

Issue 1355783002: Refactor keys and queries in datastore service and implementation. (Closed) Base URL: https://github.com/luci/gae.git@master

Patch Set: appease errcheck Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: impl/memory/datastore_index_test.go

diff --git a/impl/memory/datastore_index_test.go b/impl/memory/datastore_index_test.go

index e025de3000f2978b5430da4bb4d130bb94aa6e9c..baaf420ec77c9934eda49f25e90c9c4ed785b7a2 100644

--- a/impl/memory/datastore_index_test.go

+++ b/impl/memory/datastore_index_test.go

@@ -14,7 +14,7 @@ import (

. "github.com/smartystreets/goconvey/convey"

)

-var fakeKey = key("knd", 10, key("parentKind", "sid"))

+var fakeKey = key("parentKind", "sid", "knd", 10)

func TestCollated(t *testing.T) {

t.Parallel()

@@ -296,7 +296,7 @@ func TestIndexEntries(t *testing.T) {

}

type dumbItem struct {

- key ds.Key

+ key *ds.Key

props ds.PropertyMap

}

« no previous file with comments | « impl/memory/datastore_index_selection.go ('k') | impl/memory/datastore_query.go » ('j') | no next file with comments »