Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: impl/dummy/dummy_test.go

Issue 1355783002: Refactor keys and queries in datastore service and implementation. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: appease errcheck Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « impl/dummy/dummy.go ('k') | impl/memory/datastore.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: impl/dummy/dummy_test.go
diff --git a/impl/dummy/dummy_test.go b/impl/dummy/dummy_test.go
index 001877381181637823c69292ad0ca8450770f8ee..72630ae189f7aba0b7c2e70fed59b47edef9a599 100644
--- a/impl/dummy/dummy_test.go
+++ b/impl/dummy/dummy_test.go
@@ -50,8 +50,8 @@ func TestContextAccess(t *testing.T) {
So(dsS.Get(c), ShouldNotBeNil)
So(func() {
defer p()
- dsS.Get(c).DecodeKey("wut")
- }, ShouldPanicWith, "dummy: method Datastore.DecodeKey is not implemented")
+ _, _ = dsS.Get(c).DecodeCursor("wut")
+ }, ShouldPanicWith, "dummy: method Datastore.DecodeCursor is not implemented")
})
Convey("Memcache", func() {
@@ -59,7 +59,7 @@ func TestContextAccess(t *testing.T) {
So(mcS.Get(c), ShouldNotBeNil)
So(func() {
defer p()
- mcS.Get(c).Add(nil)
+ _ = mcS.Get(c).Add(nil)
}, ShouldPanicWith, "dummy: method Memcache.AddMulti is not implemented")
})
@@ -68,7 +68,7 @@ func TestContextAccess(t *testing.T) {
So(tqS.Get(c), ShouldNotBeNil)
So(func() {
defer p()
- tqS.Get(c).Purge("")
+ _ = tqS.Get(c).Purge("")
}, ShouldPanicWith, "dummy: method TaskQueue.Purge is not implemented")
})
« no previous file with comments | « impl/dummy/dummy.go ('k') | impl/memory/datastore.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698